[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cnl, dnv, icl, skl}: Make top_of_ram align

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35029 )

Change subject: soc/intel/{cnl, dnv, icl, skl}: Make top_of_ram align
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35029/1/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/35029/1/src/soc/intel/cannonlake/ro... 
PS1, Line 162: 	top_of_ram = ALIGN_DOWN((uintptr_t)cbmem_top(), top_of_ram_size);
> I really don't see what this change provides. […]
> yes, if top_of_ram is not aligned then above logic might block a region which might be out of our interest.