Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32835 )
Change subject: mb/google/octopus: Create Garg variant
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32835/2/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/garg/overridetree.cb:
https://review.coreboot.org/#/c/32835/2/src/mainboard/google/octopus/variant...
PS2, Line 7: register "emmc_tx_cmd_cntl" = "0x505"
I am not sure if all the EMMC Tuning and I2C tunings have been done. If done, please ignore this comment. If not, I think we can remove them and add them later after the tuning is complete. Or we can add a TODO comment at the top indicating that those tunings need to be done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32835
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a36bc5dc3d2b891b1bce86015aa264894d1434b
Gerrit-Change-Number: 32835
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 May 2019 16:05:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment