Name of user not set #1002789 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub ......................................................................
Patch Set 3:
(7 comments)
Updated comments.
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@11 PS2, Line 11: sandybridge
Sandybridge
Ack
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@12 PS2, Line 12: Tested on t440p
Confirmed that everything still renders correctly on Ubuntu with the current patchset. […]
Done
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@13 PS2, Line 13: noveau
Nouveau
Ack
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@13 PS2, Line 13: Without patches dmesg reports noveau is : unable to read the ROM of the dGPU as it has an invalid checksum (I : checked that the ROM in CBFS is correct).
Did you talk to the Nouveau folks? Sounds like something that can be fixed in Linux.
Negative. When I Googled the message it appeared to be related to the Optimus setup where the nVidia chip has no attached displays (in the muxless setup this is how it works apparently). I assume the message is benign. https://lkml.org/lkml/2019/6/2/59
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@15 PS2, Line 15: drm
DRM
Ack
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@16 PS2, Line 16: initalized
initialized
Ack
https://review.coreboot.org/c/coreboot/+/38743/2/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/acpi/peg.asl:
https://review.coreboot.org/c/coreboot/+/38743/2/src/northbridge/intel/haswe... PS2, Line 19: Name (_ADR, 0x00010000) I assume I already did? Sorry is my tab format incorrect? Still new to this.