John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30918 )
Change subject: soc/intel/apollolake: Override GLK usb clock gating register
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30918/2/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/30918/2/src/soc/intel/apollolake/chip.c@776
PS2, Line 776: reg = 0x0FCE6E5F;
We just slam in these settings?
It was determined 0x0FCE6E5F would be the right value for usb clock gating register. It could be either implemented at fsp or override by coreboot, which would reflect the same effect. After updating the value, b:12056309 shows it helps to mitigate suspend/resume failure.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30918
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50fb16f5ab0e28e79f71c7f0f8e75ac8791c0747
Gerrit-Change-Number: 30918
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 17:53:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment