Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39315 )
Change subject: mb/intel/tglrvp: add CNVi ASL entry for dynamic SSDT generation
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39315/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39315/1//COMMIT_MSG@9
PS1, Line 9: changes
change (no "s" on the end)
https://review.coreboot.org/c/coreboot/+/39315/1//COMMIT_MSG@9
PS1, Line 9: for CNVi device and
Would be good to include fact this CL exports a wake gpio, perhaps something like "for CNVi device, exports a wake gpio, and"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icdbffa0c29c9e0849a6a99f8592b6f35c0bb3207
Gerrit-Change-Number: 39315
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 05 Mar 2020 18:15:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment