Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45780 )
Change subject: amdfwtool: Remove the assumption of ROM_SIZE ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
it would also be good to remove the -DCONFIG_ROM_SIZE=$(CONFIG_ROM_SIZE) from the Makfile.inc in this patch, since that's now unused
https://review.coreboot.org/c/coreboot/+/45780/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45780/1//COMMIT_MSG@9 PS1, Line 9: Every platform passes (and need to) the --flashsize to the command parameter, : So we remove the macro definition. please add that that define that gets removed here was about a built-time rom size option and reflow the commit message to 72 characters per line