[coreboot-gerrit] [M] Change in coreboot[main]: sio/nuvoton: Implement a common ramstage ACPI LDN helper

[Keith Hui (Code Review)]

Attention is currently required from: Nico Huber, Paul Menzel.

Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82632?usp=email )

Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper
......................................................................

Patch Set 3:

(2 comments)

File src/superio/nuvoton/common/common.c:

https://review.coreboot.org/c/coreboot/+/82632/comment/d6792c30_f3b79f31?usp... :
PS1, Line 42: /* Set power state after power fail */
            : 	/* Important: Make sure the definitions in mainboard/Kconfig around
            : 	 * MAINBOARD_POWER_FAILURE_STATE and your board's cmos.layout match.
            : 	 * And if MAINBOARD_POWER_FAILURE_STATE deviates from the chip's
            : 	 * expectation (ie. 0=off, 1=on, 2=keep), this code must be adapted.
            : 	 */
> Please use one of the recommended multi-line commenting styles. I’d use: […]

Done

https://review.coreboot.org/c/coreboot/+/82632/comment/5f5a1d27_e23ca321?usp... :
PS1, Line 55: } else
            : 		byte = 0;
> if one branch has to use {} all branches need to.

Done