Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )
Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/...
PS1, Line 81: GPP_D9
Yes, please refer to Kindred MB schematic rev V2.7 20190822 […]
I meant if it was configured correctly in gpio.c in coreboot. Looks like it is done in baseboard/gpio.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35039
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c
Gerrit-Change-Number: 35039
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Aug 2019 07:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment