3 Nov
2020
3 Nov
'20
1:39 a.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47148 )
Change subject: drivers/intel/dptf: Generate ACPI identifiers only for enabled devices ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47148/1/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/47148/1/src/drivers/intel/dptf/dptf... PS1, Line 235: if (!dev->enabled) : return; :
I wonder - shouldn't we fix this at the source? i.e. […]
SGTM, I sure hope no one is expecting ACPI tables to be generated for devices that are disabled 😊
--
To view, visit https://review.coreboot.org/c/coreboot/+/47148
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib042bec7e8c68b38fafa60a8e965d781bddcd1f0
Gerrit-Change-Number: 47148
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 03 Nov 2020 01:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment