
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/64333 ) Change subject: mb/google/brya/var/kinox: Set memory SMBus addresses to 0x52, 0x50 ...................................................................... mb/google/brya/var/kinox: Set memory SMBus addresses to 0x52, 0x50 Follow the Kinox_schematic_R01_20220418.pdf to set memory SMBus addresses to 0x52, 0x50. BUG=b:231398371 TEST=Build and boot to OS with either 1 or 2 DIMM slots populated. Signed-off-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com> Change-Id: I32bb4f62a6b8a485ac757a60f5d16adb69109e2f Reviewed-on: https://review.coreboot.org/c/coreboot/+/64333 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Frank Wu <frank_wu@compal.corp-partner.google.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> --- M src/mainboard/google/brya/variants/kinox/memory.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Frank Wu: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/kinox/memory.c b/src/mainboard/google/brya/variants/kinox/memory.c index ad33e9c..f979035 100644 --- a/src/mainboard/google/brya/variants/kinox/memory.c +++ b/src/mainboard/google/brya/variants/kinox/memory.c @@ -29,3 +29,10 @@ { return &ddr4_mem_config; } + +void variant_get_spd_info(struct mem_spd *spd_info) +{ + spd_info->topo = MEM_TOPO_DIMM_MODULE; + spd_info->smbus[0].addr_dimm[0] = 0x52; + spd_info->smbus[1].addr_dimm[0] = 0x50; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/64333 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32bb4f62a6b8a485ac757a60f5d16adb69109e2f Gerrit-Change-Number: 64333 Gerrit-PatchSet: 5 Gerrit-Owner: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Frank Wu <frank_wu@compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: merged