Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35225 )
Change subject: soc/intel/common/block/cse: Move me_read_config32() to common code ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35225/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35225/2/src/soc/intel/common/block/... PS2, Line 518: index = 1
IMHO, you don't need to add this print then if no benefit, leave it on caller if wishes to add debug […]
for #1 refer to https://github.com/coreboot/coreboot/blob/22d66efe652534a476e8165aa902138e19...
for #2 refer to https://github.com/coreboot/coreboot/blob/22d66efe652534a476e8165aa902138e19...