[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Raul Rangel (Code Review)]

Attention is currently required from: Patrick Rudolph.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 27:

(2 comments)

Patchset:

PS27: 
Looks like this CL is breaking the framebuffer on picasso devices:

Calling Option ROM...
... Option ROM returned.
VBE: Getting information about VESA mode 41d4
VBE: resolution:  1920x1080@32
VBE: framebuffer: 0xd0000000
VBE: Setting VESA mode 41d4
fb_add_framebuffer_info_ex: blue_mask_size: 8, green_mask_size: 8, red_mask_size: 8, reserved_mask_size: 0
fb_add_framebuffer_info_ex: BPP=32 and channel bit mask=24 doesn't match. This is a driver bug.

File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/comment/19485ad9_f9654f8d 
PS27, Line 53: 		       " This is a driver bug.\n", __func__, fb->bits_per_pixel, bpp_mask);
Looks like this check is breaking the framebuffer on picasso:

Calling Option ROM...
... Option ROM returned.
VBE: Getting information about VESA mode 41d4
VBE: resolution:  1920x1080@32
VBE: framebuffer: 0xd0000000
VBE: Setting VESA mode 41d4
fb_add_framebuffer_info_ex: blue_mask_size: 8, green_mask_size: 8, red_mask_size: 8, reserved_mask_size: 0
fb_add_framebuffer_info_ex: BPP=32 and channel bit mask=24 doesn't match. This is a driver bug.

If I comment out the `return NULL` I get the following:

framebuffer_info: bytes_per_line: 7680, bits_per_pixel: 32
                   x_res x y_res: 1920 x 1080, size: 8294400 at 0xd0000000

How should we go about restoring the picasso framebuffer?