Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41735 )
Change subject: sb/intel/i82371eb: Implement SMBus Control Method Interface support ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41735/4/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/Kconfig:
https://review.coreboot.org/c/coreboot/+/41735/4/src/southbridge/intel/i8237... PS4, Line 9: config HAVE_SCMI : bool : default y if SOUTHBRIDGE_INTEL_I82371EB : help : Southbridges select Y if their DSDT implements SCMI. : See http://smbus.org/specs/smbus_cmi10.pdf for details. : : config USE_SCMI : bool "Enable SMBus Control Method Interface (SCMI)" : depends on HAVE_SCMI && HAVE_ACPI_TABLES : help : Adds extra access methods conforming to the SMBus Control Method Interface (SCMI) : specification to the SMBus ACPI device. This may be your only access to SMBus : devices if other means fail. : : ASUS P3B-F mainboard requires this. : : If you say Y here, you will have to blacklist the native driver and instead use : i2c-scmi driver to access SMBus-connected devices. This needs to be guarded:
if SOUTHBRIDGE_INTEL_I82371EB
config HAVE_SCMI ...
endif