Philipp Deppenwiese has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/29864
Change subject: cpu/intel/microcode: Enable verbose output ......................................................................
cpu/intel/microcode: Enable verbose output
* Check if microcode is really updated. * Enable more verbose output.
Change-Id: I534aa790c8d37b5f1603e1715635446835513a65 Signed-off-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M src/cpu/intel/microcode/microcode.c 1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/29864/1
diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c index d217cfd..96b9e4e 100644 --- a/src/cpu/intel/microcode/microcode.c +++ b/src/cpu/intel/microcode/microcode.c @@ -89,8 +89,12 @@ current_rev = read_microcode_rev();
/* No use loading the same revision. */ - if (current_rev == m->rev) + if (current_rev == m->rev) { +#if !defined(__ROMCC__) + printk(BIOS_INFO, "microcode: Update skipped, already up-to-date\n"); +#endif return; + }
#if ENV_RAMSTAGE /*SoC specific check to update microcode*/ @@ -104,12 +108,20 @@ msr.hi = 0; wrmsr(IA32_BIOS_UPDT_TRIG, msr);
+ current_rev = read_microcode_rev(); + if (current_rev == m->rev) { #if !defined(__ROMCC__) - printk(BIOS_DEBUG, "microcode: updated to revision " + printk(BIOS_INFO, "microcode: updated to revision " "0x%x date=%04x-%02x-%02x\n", read_microcode_rev(), m->date & 0xffff, (m->date >> 24) & 0xff, (m->date >> 16) & 0xff); #endif + return; + } + +#if !defined(__ROMCC__) + printk(BIOS_INFO, "microcode: Update failed\n"); +#endif }
uint32_t get_current_microcode_rev(void)