Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37210 )
Change subject: [WIP] soc/amd/common: Remove guards on ACPIMMIO utils ......................................................................
Patch Set 1:
(1 comment)
What would happen if there was a new SOC that did not supported one of these MMIO? Or if it supported a different one? I agree that apparently Picasso and Stoney Ridge support the same set... but the guards where established for this situation and I'm not sure if it's wise to remove them.
https://review.coreboot.org/c/coreboot/+/37210/1/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/gpio_banks.h:
https://review.coreboot.org/c/coreboot/+/37210/1/src/soc/amd/common/block/in... PS1, Line 21: acpimmio_map Why the need for this, being that nothing was added to this header? I can see it's wide spread, but I don't understand why.