Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45408 )
Change subject: mb/ocp/deltalake: Override uart base address via VPD variable
......................................................................
Patch Set 12:
(2 comments)
This change doesn't touch bootblock_mainboard_early_init(void).
How could it have been found working?
https://review.coreboot.org/c/coreboot/+/45408/12/src/mainboard/ocp/deltalak...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/45408/12/src/mainboard/ocp/deltalak...
PS12, Line 36: atol
Make use of get_uart_for_console
https://review.coreboot.org/c/coreboot/+/45408/12/src/mainboard/ocp/deltalak...
PS12, Line 44: 0x3e8
Is something decoding this address? Does FSP set LPC decode ranges for those addresses?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45408
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55a85d6f137ef1aba95466e7b094740b685bf9bd
Gerrit-Change-Number: 45408
Gerrit-PatchSet: 12
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 06:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment