[coreboot-gerrit] Change in coreboot[master]: cpu/x86/lapic: Split virtual_wire_mode_init()

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Werner Zeh.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55261 )

Change subject: cpu/x86/lapic: Split virtual_wire_mode_init()
......................................................................

Patch Set 13:

(1 comment)

File src/cpu/x86/lapic/lapic.c:

https://review.coreboot.org/c/coreboot/+/55261/comment/11796f6f_b16c840f 
PS13, Line 67: /* Enable the local APIC */
             : 	if (need_lapic_init())
             : 		enable_lapic();
             : 	else if (!CONFIG(UDELAY_LAPIC))
             : 		disable_lapic();
             : 
             : 	/* This programming is for PIC mode i8259 interrupts to be delivered to CPU
             : 	   while LAPIC is enabled. */
             : 	if (need_lapic_init())
             : 		lapic_virtual_wire_mode_init();
> This should be equivalent and simpler: […]

AFAICS lapic_virtual_wire_mode_init() is not a required part of SMP bringup, so expect some suggestions to change this. I think LVT0 programming for ExtINT is required without IOAPIC, and irrelevant with IOAPIC.