Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44196 )
Change subject: mrc_cache: Update mrc_cache data in romstage ......................................................................
Patch Set 24:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/mrc_cache/Kcon... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/mrc_cache/Kcon... PS24, Line 45: later to MRC_CACHE. Probably we should add: This is selected for platforms which either do not support writes to SPI flash in early stages()BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES) or the platforms that need to write back the MRC data in late ramstage boot states(MRC_WRITE_NV_LATE).
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/spi/Kconfig File src/drivers/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/44196/24/src/drivers/spi/Kconfig@45 PS24, Line 45: BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES Addition of this Kconfig should be its own separate CL along with selecting it for platforms that need it.