Attention is currently required from: Mario Scheithauer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69611 )
Change subject: device/mdio: Provide helper functions for read and write
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/device/mdio.c:
https://review.coreboot.org/c/coreboot/+/69611/comment/d5ba96cc_9b91454d
PS4, Line 27: 0
Do you know if the MDIO spec specifies a default value when attempting to read from a non-existing device? It'd be good to use the same value here.
For PCI devices, this value would be all ones.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69611
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I293d93435d27269a071b4b9b94a1b55307c575a7
Gerrit-Change-Number: 69611
Gerrit-PatchSet: 4
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 11:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment