Attention is currently required from: Carlos López, Joel Bueno, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Joel Bueno. ( https://review.coreboot.org/c/coreboot/+/85800?usp=email )
Change subject: commonlib/device_tree: fix 64-bit misaligned member access
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85800/comment/a58e836a_eaa95a6d?usp... :
PS4, Line 87: uint32_t high = be32dec(ptr);
nit:
could you add a comment above here like:
```
FDT spec only guarantees a 4 byte alignment.
```
https://review.coreboot.org/c/coreboot/+/85800/comment/3ee696bd_f9b61376?usp... :
PS4, Line 95: uint32_t high = be32dec(ptr);
same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85800?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I567103bcd956b10fab64c5e63018315924ec0d2b
Gerrit-Change-Number: 85800
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Bueno
joel.bueno@openchip.com
Gerrit-Reviewer: Carlos López
carlos.lopezr4096@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Joel Bueno
joel.bueno@openchip.com
Gerrit-Attention: Carlos López
carlos.lopezr4096@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:44:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes