Attention is currently required from: Tarun Tuli, Martin L Roth, Jérémy Compostella, Andrey Petrov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull ligfxinit in romstage ......................................................................
Patch Set 1:
(3 comments)
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/69757/comment/579bd242_86264c34 PS1, Line 122: This "illegal globals" check is because global variables in these sections don't get initialized in CAR stages. In particular, CB:56189 should patch one of the reasons why you have troubles with this. It'd be nice to try flipping the boolean so that it starts as False.
If memory serves right, https://review.coreboot.org/q/topic:ada-in-romstage deals with this differently, but it doesn't pull in that much code (no libgfxinit, just libhwbase).
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/69757/comment/88674f19_7674a3dc PS1, Line 47: static void save_memory_training_data(uint32_t fsp_version) : : static uint8_t temp_ram[CONFIG_FSP_TEMP_RAM_SIZE] __aligned(sizeof(uint64_t)); Something funky happened here
https://review.coreboot.org/c/coreboot/+/69757/comment/64e85d46_31a32046 PS1, Line 348: gma_gfxinit(&lightup_ok); We might need to make this more flexible, so that you can initialize a VGA textmode framebuffer in romstage and a linear "high-resolution" framebuffer in ramstage.