[coreboot-gerrit] [S] Change in coreboot[master]: acpigen: Add a runtime method to override exposed _Sx sleep states

[Jakub Czapiga (Code Review)]

Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak, Maximilian Brune, Arthur Heymans, Werner Zeh.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 )

Change subject: acpigen: Add a runtime method to override exposed _Sx sleep states
......................................................................

Patch Set 10:

(1 comment)

File src/acpi/acpigen.c:

https://review.coreboot.org/c/coreboot/+/74762/comment/a4485d81_e96046bf 
PS10, Line 2377: uint32_t sleep_enable = (enable_s1 << 0) | (enable_s2 << 1)
               : 		| (enable_s3 << 2) | (enable_s4 << 3);
This is still not safe. It's easy to create buggy code by passing any non-zero value as enabled state instead of one. I think you should change `enable_sX` type to either `int` or `bool`. And then:
```
uint32_t sleep_enable = 0;
if (enable_s1)
    sleep_enable |= BIT(0);
if (enable_s2)
    sleep_enable |= BIT(1);
...
```

This will be compatible with asserts above, which check whether `enable_sX` is zero or non-zero.