Attention is currently required from: Frank Wu, John Su, Jason Nien, Matt DeVillier, Chris Wang, Martin Roth.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69565 )
Change subject: mb/google/skyrim/var/frostflow: Set Package Power Parameters
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/skyrim/variants/frostflow/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69565/comment/bf2aa1e8_817cbac8
PS4, Line 10: register "stapm_time_constant_s" = "200"
Hi Tim, […]
Ah, right, that's what I was missing.
I wonder if it would make more sense to move the values from `skyrim/overridetree.cb` into `baseboard/devicetree.cb`, since they all need them defined anyway. That would avoid the duplication.
CL is available here:
https://review.coreboot.org/c/coreboot/+/69904
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15a69df1436aba05bc19eaffd79394e5ca9bdb3a
Gerrit-Change-Number: 69565
Gerrit-PatchSet: 4
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 24 Nov 2022 00:15:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu
frank_wu@compal.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment