15 Mar
2021
15 Mar
'21
5:20 p.m.
Attention is currently required from: Martin Roth, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51436 )
Change subject: Makefile.inc: Don't compile bare structs with asan-global=1 ......................................................................
Patch Set 1:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51436/comment/08a0acfd_d309bb86 PS1, Line 338: $(CC_ramstage) -MMD $(CPPFLAGS_ramstage) $(CFLAGS_ramstage) --param asan-globals=0 $$(ramstage-c-ccopts) -include $(KCONFIG_AUTOHEADER) -MT $(2) -o $(2).tmp -c $(1) && \ Not that I mind too much, but I suppose this breaks building on non-crossgcc toolchains that come without this option?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51436
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a13bd9f4b11530a6dd5f572059fed851db44757
Gerrit-Change-Number: 51436
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 15 Mar 2021 06:20:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment