Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55170 )
Change subject: mb/google/brya: Set SerialIoI2cMode for I2C4 as PchSerialIoDisabled
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55170/comment/dfec4e83_cceacde2
PS2, Line 121: .i2c[4] = {
: .speed = I2C_SPEED_FAST,
: },
Drop this too?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55170
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I94c72b7fac9d8a001913b5faa2c0c8a3e8b701e9
Gerrit-Change-Number: 55170
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 03 Jun 2021 17:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment