Attention is currently required from: Derek Huang, Paul Menzel, Robert Chen, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email )
Change subject: mb/google/dedede/var/drawcia: Correct board version in variant_devicetree_update
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84953/comment/aeb1653e_b4f36ed9?usp... :
PS11, Line 7: mb/google/dedede/var/drawcia: Correct board version in variant_devicetree_update
Keep this line to less than 70 characters. May be:
`mb/google/dedede/var/drawcia: Update ext_vr for board version > b`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84953?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a
Gerrit-Change-Number: 84953
Gerrit-PatchSet: 11
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Mon, 04 Nov 2024 18:09:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No