[coreboot-gerrit] Change in coreboot[master]: amdfwtool: Take a config file instead of command line parameters

[Bao Zheng (Code Review)]

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )

Change subject: amdfwtool: Take a config file instead of command line parameters
......................................................................

Patch Set 54:

(3 comments)

https://review.coreboot.org/c/coreboot/+/42859/47/src/soc/amd/picasso/Makefi... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42859/47/src/soc/amd/picasso/Makefi... 
PS47, Line 125: "3rdparty/amd_blobs/picasso/PSP"
> Done.  […]

Ack. Other places have been marked as done. This comment is left to be approved.

https://review.coreboot.org/c/coreboot/+/42859/47/src/soc/amd/stoneyridge/Ma... 
File src/soc/amd/stoneyridge/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42859/47/src/soc/amd/stoneyridge/Ma... 
PS47, Line 105: ifeq ($(CONFIG_AMD_APU_STONEYRIDGE),y)
> Done. Changed.

Done

https://review.coreboot.org/c/coreboot/+/42859/47/src/southbridge/amd/pi/hud... 
File src/southbridge/amd/pi/hudson/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/42859/47/src/southbridge/amd/pi/hud... 
PS47, Line 81: "3rdparty/blobs/southbridge/amd/avalon/PSP"
> Again, use a Kconfig option please.

Done