Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35117 )
Change subject: soc/sifive/fu540: test and fix code of fu540 spi
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35117/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35117/1//COMMIT_MSG@7
PS1, Line 7: soc/sifive/fu540 : test and fix code of fu540 spi
Please remove the space before the colon.
Done
https://review.coreboot.org/c/coreboot/+/35117/1//COMMIT_MSG@9
PS1, Line 9: I tested the SPI through the SD card and fixed some problems.
Please elaborate on the problems.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60033a148c21bbd5b4946580f6cab0b439d346c6
Gerrit-Change-Number: 35117
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@hardenedlinux.org
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 11:38:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment