[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma: Move IGD OpRegion to CBMEM

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40724 )

Change subject: drivers/intel/gma: Move IGD OpRegion to CBMEM
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr... 
File src/soc/intel/apollolake/graphics.c:

https://review.coreboot.org/c/coreboot/+/40724/6/src/soc/intel/apollolake/gr... 
PS6, Line 23: uint32_t reg32 = pci_read_config32(dev, PCI_COMMAND);
            : 	reg32 |= PCI_COMMAND_MASTER;
            : 	pci_write_config32(dev, PCI_COMMAND, reg32);
> This now happens on the RUN_FSP_GOP path too.

Ah, yes. I made the assumption that RUN_FSP_GOP implies that FSP already
set it. Should I document it? or get rid of the assumption?