Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40677 )
Change subject: soc/amd/{common,picasso}: Move GFX device from static ASL to SSDT
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40677/4/src/soc/amd/common/block/gr...
File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/40677/4/src/soc/amd/common/block/gr...
PS4, Line 26: graphics_fill_ssdt
I don't know the history here. Why do we add it to the SSDT instead of the DSDT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a967cdc43b74f786e645d3fb666506070851a99
Gerrit-Change-Number: 40677
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 25 Apr 2020 14:14:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment