Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44383 )
Change subject: soc/ti/am335x: Fix timer implementation ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44383/5/src/soc/ti/am335x/timer.c File src/soc/ti/am335x/timer.c:
https://review.coreboot.org/c/coreboot/+/44383/5/src/soc/ti/am335x/timer.c@1... PS5, Line 10: struct am335x_dmtimer *dmtimer_2 = (struct am335x_dmtimer *)0x48040000;
please use a define or a symbol from the memlayout file to get the address […]
Thanks, have defined a symbol now.
I didn't think volatile is necessary on this as it's only accessed through read32/write32 (which cast the addresses as volatile). This seems to be consistent with the way these sort of struct are used across the tree?