Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao, Martin Roth, Fred Reitberger, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69150 )
Change subject: soc/amd/morgana: Add 32M support
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
This change makes so many assumptions about how things are going to work, and breaks so many current […]
So where should the AMDFW and coreboot be located for Birman?
The AMDFW should be at relative 0x20000, which is defined by HW. So it should be at bottom 16M. The coreboot stages should be upper 16M, otherwise the running address pointer and data loading don't have the correct address.
So how is the amdfw "inside" CBFS?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0b5a75f828033b29c378bed9a939b23d7f19140
Gerrit-Change-Number: 69150
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 11 Nov 2022 03:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment