Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44452 )
Change subject: mb/google/asurada: Fixup BOOT_DEVICE_SPI_FLASH_BUS default value ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
just one nit
https://review.coreboot.org/c/coreboot/+/44452/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/Kconfig:
https://review.coreboot.org/c/coreboot/+/44452/2/src/mainboard/google/asurad... PS2, Line 45: : # On MT8192 the SPI flash is actually using a SPI-NOR controller with its own bus. : # The number here should be a virtual value as (SPI_BUS_NUMBER + 1). Better to put the comment above the config, e.g.
# On MT8192 ... # The number ... config BOOT_DEVICE int default 9