Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31984 )
Change subject: mb/mainboard/google/hatch/variants: Set tcc_offset value
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31984/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31984/3//COMMIT_MSG@10
PS3, Line 10: activaction
activation
https://review.coreboot.org/#/c/31984/3/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31984/3/src/mainboard/google/hatch/variants/...
PS3, Line 75: "10" # TCC of 90C
potential idea for a follow-up commit: make a field "tcc" that takes degrees and convert it in the code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31984
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifee0fcc326530622b04e60af0f3b9cb9e3aea7ea
Gerrit-Change-Number: 31984
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Mar 2019 09:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment