Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7
......................................................................
Patch Set 2:
(1 comment)
.
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z...
File src/mainboard/gigabyte/ga-z170x-gaming7/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z...
PS2, Line 2: bool "GA-Z170X-Gaming 7"
I think it should match with your Kconfig's MAINBOARD_PART_NUMBER's default value? Like only "Z170X-Gaming 7".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2c69bddd22cbd8f797dbb57370a4d8e5afa63bc
Gerrit-Change-Number: 38920
Gerrit-PatchSet: 2
Gerrit-Owner: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pavel Sayekat
Gerrit-Comment-Date: Sat, 15 Feb 2020 19:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment