Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Paul Menzel.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79283?usp=email )
Change subject: mainboard/amd/birman: Add Birmanplus board variant support for Phoenix SOC
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79283/comment/86c9a4ab_227dbf3f :
PS5, Line 7: src/mainboard/amd/birman : Add
Please remove the space before the colon.
Done
https://review.coreboot.org/c/coreboot/+/79283/comment/42dd30ba_dc208f79 :
PS5, Line 7: src/mainboard/amd/birman : Add a new board variant for Phoenix SOC
Please mention the new variant.
Done
https://review.coreboot.org/c/coreboot/+/79283/comment/881c5c78_e50eeec3 :
PS5, Line 7: src/
Please remove `src`.
Done
https://review.coreboot.org/c/coreboot/+/79283/comment/fdca0bc1_cf0ffeb3 :
PS5, Line 12: TEST :
TEST=
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79283?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40f196d8a662d19e424511febca24edb88d686dd
Gerrit-Change-Number: 79283
Gerrit-PatchSet: 6
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 01 Dec 2023 01:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment