[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: Add support for FSP MR2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29661 )

Change subject: soc/intel/braswell: Add support for FSP MR2
......................................................................

Patch Set 5:
> Patch Set 5:
> > Usage of 'old non MR2 fields should be moved to 'Braswell' mainboards.
>
> but the current header is newer than MR2 (1.1.7.0 v 1.1.4.1). and since all existing boards compile with it, seems like MR2 should be the special case/exception requiring manual selection

Are you sure existing boards use use 3rdparty FspUpdVpd.h? I tested with 3rdparty FspUpdVpd.h and this causes build errors on USB and I2C fields in braswell/chip.c.
MR1 has version 1.1.7.0, MR2 1.1.4.1.