Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39812 )
Change subject: mb/google/dedede: Read DRAM population strap
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39812/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39812/2/src/mainboard/google/dedede...
PS2, Line 351: GPP_S0
This will have to be configured in early_gpio_table as well since it is being used in romstage.
True, thanks for pointing out.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39812
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69583f35ffc219bae9ce06bd4ba9898ed0d4d21d
Gerrit-Change-Number: 39812
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 25 Mar 2020 04:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment