[coreboot-gerrit] [M] Change in coreboot[master]: mb/amd/birman/port_descriptors.c: Update DXIO for birman

[Fred Reitberger (Code Review)]

Attention is currently required from: Jason Glenesk, Felix Held.

Fred Reitberger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69705 )

Change subject: mb/amd/birman/port_descriptors.c: Update DXIO for birman
......................................................................

mb/amd/birman/port_descriptors.c: Update DXIO for birman

Update DXIO descriptors for birman per schematic 105-D67000-00B v0.7

Signed-off-by: Fred Reitberger 
Change-Id: I76cf6715b60a1857bf58349d70a623bf043594fe
---
M src/mainboard/amd/birman/port_descriptors.c
1 file changed, 90 insertions(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/69705/1

diff --git a/src/mainboard/amd/birman/port_descriptors.c b/src/mainboard/amd/birman/port_descriptors.c
index f2ed5c5..b223dc1 100644
--- a/src/mainboard/amd/birman/port_descriptors.c
+++ b/src/mainboard/amd/birman/port_descriptors.c
@@ -6,48 +6,100 @@
 #include <soc/platform_descriptors.h>
 #include <types.h>

-/* TODO: Update for birman */
-
 static const fsp_dxio_descriptor birman_dxio_descriptors[] = {
-	{
+	{ /* MXM */
    	.engine_type = PCIE_ENGINE,
    	.port_present = true,
    	.start_logical_lane = 0,
-		.end_logical_lane = 0,
-		.device_number = 2,
+		.end_logical_lane = 3,
+		.device_number = 1,
    	.function_number = 1,
    	.link_speed_capability = GEN3,
    	.turn_off_unused_lanes = true,
-		.link_aspm = 2,
-		.link_hotplug = 3,
-		.clk_req = CLK_REQ3,
+		.link_aspm = ASPM_L1,
+		.link_hotplug = 0,
+		.gpio_group_id = GPIO_26,
+		.clk_req = CLK_REQ0,
    },
-	{
+	{ /* NVMe SSD0 */
    	.engine_type = PCIE_ENGINE,
    	.port_present = true,
-		.start_logical_lane = 1,
-		.end_logical_lane = 1,
+		.start_logical_lane = 16,
+		.end_logical_lane = 19,
+		.device_number = 2,
+		.function_number = 4,
+		.link_speed_capability = GEN3,
+		.turn_off_unused_lanes = true,
+		.link_aspm = ASPM_L1,
+		.link_hotplug = 0,
+		.gpio_group_id = GPIO_27,
+		.clk_req = CLK_REQ2,
+	},
+	{ /* WLAN */
+		.engine_type = PCIE_ENGINE,
+		.port_present = true,
+		.start_logical_lane = 15,
+		.end_logical_lane = 15,
    	.device_number = 2,
    	.function_number = 2,
    	.link_speed_capability = GEN3,
    	.turn_off_unused_lanes = true,
-		.link_aspm = 2,
-		.link_hotplug = 3,
-		.clk_req = CLK_REQ1,
+		.link_aspm = ASPM_L1,
+		.link_hotplug = 0,
+		.clk_req = CLK_REQ3,
    },
-	{
+	{ /* SD */
    	.engine_type = PCIE_ENGINE,
    	.port_present = true,
-		.start_logical_lane = 2,
-		.end_logical_lane = 3,
+		.start_logical_lane = 13,
+		.end_logical_lane = 13,
+		.device_number = 2,
+		.function_number = 1,
+		.link_speed_capability = GEN3,
+		.turn_off_unused_lanes = true,
+		.link_aspm = ASPM_L1,
+		.link_hotplug = 0,
+		.clk_req = CLK_REQ5,
+	},
+	{ /* NVMe SSD1 */
+		.engine_type = PCIE_ENGINE,
+		.port_present = true,
+		.start_logical_lane = 8,
+		.end_logical_lane = 11,
+		.device_number = 1,
+		.function_number = 2,
+		.link_speed_capability = GEN3,
+		.turn_off_unused_lanes = true,
+		.link_aspm = ASPM_L1,
+		.link_hotplug = 0,
+		.gpio_group_id = GPIO_26,
+		.clk_req = CLK_REQ1,
+	},
+	{ /* GBE */
+		.engine_type = PCIE_ENGINE,
+		.port_present = true,
+		.start_logical_lane = 12,
+		.end_logical_lane = 12,
+		.device_number = 1,
+		.function_number = 3,
+		.link_speed_capability = GEN3,
+		.turn_off_unused_lanes = true,
+		.link_aspm = ASPM_L1,
+		.link_hotplug = 0,
+		.clk_req = CLK_REQ3,
+	},
+	{ /* WWAN */
+		.engine_type = PCIE_ENGINE,
+		.port_present = true,
+		.start_logical_lane = 14,
+		.end_logical_lane = 14,
    	.device_number = 2,
    	.function_number = 3,
    	.link_speed_capability = GEN3,
    	.turn_off_unused_lanes = true,
-		.link_aspm = 2,
-		.link_hotplug = 3,
-		.gpio_group_id = GPIO_27,
-		.clk_req = CLK_REQ0,
+		.link_aspm = ASPM_L1,
+		.link_hotplug = 0,
+		.clk_req = CLK_REQ4,
    },
 };

@@ -98,7 +150,7 @@
    connector_type = eeprom_connector_type_data[1] | eeprom_connector_type_data[0] << 8;

switch (connector_type) {
-	case 0xc:
+	case 0x0c:
    	printk(BIOS_DEBUG, "Configuring DDI1 as HDMI.\n");
    	return DDI_HDMI;
    	break;
@@ -110,6 +162,10 @@
    	printk(BIOS_DEBUG, "Configuring DDI1 as eDP.\n");
    	return DDI_EDP;
    	break;
+	case 0x17:
+		printk(BIOS_DEBUG, "Configuring DDI1 as USB-C.\n");
+		return DDI_DP_W_TYPEC;
+		break;
    default:
    	printk(BIOS_WARNING, "Unexpected display connector type %x. Disabling DDI1.\n",
    	       connector_type);