Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45123 )
Change subject: mb/Kconfig: Move MAINBOARD_FAMILY type definition to mb/Kconfig ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig File src/mainboard/Kconfig:
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig@14 PS2, Line 14: config MAINBOARD_FAMILY If declared unconditionally, it renders the #ifdef in `arch/x86/smbios.c` useless. Maybe replace it with a check that the string is not empty?
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig@17 PS2, Line 17: identifies the family to which a particular computer belongs I don't think this description is helpful. Would be worth to mention that this goes into the SMBIOS type1 table (not type2 which is the mainboard one, *shrug*).
https://review.coreboot.org/c/coreboot/+/45123/2/src/mainboard/Kconfig@17 PS2, Line 17: This text string identifies the family to which a particular computer belongs. Nit, should be indented with tab + 2 spaces, IIRC.