Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )
Change subject: mainboard/google/volteer: Enable long cr50 ready pulses ......................................................................
Patch Set 15:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44359/15/src/mainboard/google/volte... File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44359/15/src/mainboard/google/volte... PS15, Line 9: #include <ec/google/chromeec/ec.h> I don't think this is needed either
https://review.coreboot.org/c/coreboot/+/44359/15/src/mainboard/google/volte... PS15, Line 35: S03.4 /* * Multi-line comments should look * like this. */
Also S0i3.4