Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier, Nick Kochlowski.
Paul Menzel has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85195?usp=email )
Change subject: soc/amd/phoenix/pci_irq_routing.c: Populate PCI IRQ routing table
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85195/comment/9ba8e46b_71db5a43?usp... :
PS8, Line 13: TEST=Successful build and boot. There are no longer warnings about not being able to write PCI IRQ assignments.
Please re-flow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/85195/comment/242d198c_c7f19a0d?usp... :
PS8, Line 18: [WARN ] Can't write PCI IRQ assignments because 'mainboard_pirq_data'
: structure does not exist
This could be one line, as it’s logs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id014ff3e675831eec42bc46c0a76271341e0e3e4
Gerrit-Change-Number: 85195
Gerrit-PatchSet: 8
Gerrit-Owner: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 11 Dec 2024 15:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes