Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38301 )
Change subject: timestamps: Fix syncing to CBMEM ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38301/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38301/1//COMMIT_MSG@11 PS1, Line 11: subtracted twice. Not very obvious, but the second time it's supposed to subtract 0 (`ts_cbmem_table->base_time` is not set yet).
https://review.coreboot.org/c/coreboot/+/38301/1/src/lib/timestamp.c File src/lib/timestamp.c:
https://review.coreboot.org/c/coreboot/+/38301/1/src/lib/timestamp.c@155 PS1, Line 155: printk(BIOS_INFO, "Timestamp - %s: %llu\n", timestamp_name(id), ts_time); Also makes this output relative to the `base_time`.
https://review.coreboot.org/c/coreboot/+/38301/1/src/lib/timestamp.c@223 PS1, Line 223: if (ts_cbmem_table->base_time == 0)
Hmm.. […]
Well, the code looks odd anyway: Unconditionally migrate entries but conditionally migrate `base_time`? It's confusing.