[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Refactor S3 helpers

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31490 )

Change subject: soc/amd/common: Refactor S3 helpers
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/31490/6/src/soc/amd/common/block/pi... 
File src/soc/amd/common/block/pi/agesawrapper.c:

https://review.coreboot.org/c/coreboot/+/31490/6/src/soc/amd/common/block/pi... 
PS6, Line 318: 	if (OemS3Save(&RtbParams->S3DataBlock) != AGESA_SUCCESS)
> Memory training data is also useful on cold boots: if the memory is the same, why waste time retrain […]

Unfortunately, stoney had no way of loading the timing data back into one of the memory components on a cold boot, so the memory training data was only useful on resume from S3.  I don't remember if it was the PHY or something else, but we tried to reuse the memory timings at boot as we do on intel platform, and were told that it wasn't possible.