Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35888 )
Change subject: src/arch/x86/smbios.c: add SMBIOS type 16 structure
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35888/2/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/35888/2/src/arch/x86/smbios.c@530
PS2, Line 530: int __weak fill_mainboard_smbios_type16(unsigned long *current, int *handle)
that might collide with the type16 installed by some north-bridges. […]
Do you suggest to use .get_smbios_data from device_operations struct, as it is done in e.g. amd/amdfam10/northbridge?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I590ebf89ecb3f97a9ce028ca34696e5809d66d49
Gerrit-Change-Number: 35888
Gerrit-PatchSet: 2
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 06 Nov 2019 10:16:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment