Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32542 )
Change subject: mb/siemens/mc_apl2: Limit SD-Card speed to DDR50 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32542/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c:
https://review.coreboot.org/#/c/32542/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 47: dev = dev_find_slot(0, PCH_DEVFN_SDCARD);
Would pcidev_path_on_root(PCH_DEVFN_SDCARD) work here instead? […]
Sure, pcidev_path_on_root() should be fine here as well. Will change.
https://review.coreboot.org/#/c/32542/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 55: write32(base + SD_CAP_BYP, SD_CAP_BYP_EN);
Looks like arithmetics performed on void pointer. […]
Will change to uint32 arithmetic and cast to void* on write32/read32.