Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33033 )
Change subject: superio/common: Add ssdtgen for generic SuperIOs ......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic... File src/superio/common/generic.c:
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic... PS19, Line 29: res->flags |= IORESOURCE_STORED;
the resource gets marked as stored, but isn't stored here. […]
it marks the SuperIO config port as used and then prints it in report_resource_stored(). As the SIO always decodes that range there's no need to touch the SIO config space.
https://review.coreboot.org/c/coreboot/+/33033/19/src/superio/common/generic... PS19, Line 167: * coreboot's generic allocator doesn't expect them behind PnP devices.
is it a good idea to make this device a pnp device and not a generic device that has to contain pnp […]
The reason why it is an pnp device is simple: it allows to store the config port in devicetree and it can be read using dev->path.pnp.port. The dev->path.pnp.port then will be used to generate the OperationRegion at the right offset in the ssdtgen on top.