Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33395 )
Change subject: mb/google/octopus: Override VBT selection for Garg
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/garg/mainboard.c:
https://review.coreboot.org/#/c/33395/3/src/mainboard/google/octopus/variant...
PS3, Line 30: google_chromeec_cbi_get_sku_id
Hi Karthik, […]
This should be similar function like variant_board_sku which was in multiple platforms like nami and reef. And the header file associated to it is various.h in baseboard dir.
As a result, we can just rename it to variant_board_sku and remove the static limitation then all others can call it instead of google_chromeec_cbi_get_sku_id with additional check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33395
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c0ec086496eaf217ea8e326f5084d886d0e698f
Gerrit-Change-Number: 33395
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 12 Jun 2019 06:35:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-MessageType: comment