Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31900 )
Change subject: device: Rename scan_static_bus() -> enable_static_devices()
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31900/2/src/device/root_device.c
File src/device/root_device.c:
https://review.coreboot.org/c/coreboot/+/31900/2/src/device/root_device.c@46
PS2, Line 46: enable_static_devices
It is. scan_bus() actually is supposed to perform both, it first enables all […]
Resolved, I guess
https://review.coreboot.org/c/coreboot/+/31900/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/hda/hda.c:
https://review.coreboot.org/c/coreboot/+/31900/1/src/soc/intel/common/block/...
PS1, Line 72: .scan_bus = enable_static_devices,
We are dealing with static bus with at least one child? So we can evaluate the path type from that […]
Resolved, I guess
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c9dc437b6117112bb28550855a2c38044dfbfa5
Gerrit-Change-Number: 31900
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Sun, 06 Oct 2019 13:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment