Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38779 )
Change subject: vboot: push clear recovery mode switch until BS_WRITE_TABLES
......................................................................
Patch Set 3:
BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, clear_recovery_mode_switch, NULL);
You might want to do this at BS_ON_EXIT so that it does not clear the switch before it is used to log.
BTW, can this be done as part of a callback from vboot when it decides to clear the recovery reason? i.e. recovery reason in VBNV and recovery mode switches can potentially be cleared at the same time?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30c02787c620b937e5a50a5ed94ac906e3112dad
Gerrit-Change-Number: 38779
Gerrit-PatchSet: 3
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Feb 2020 23:39:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment